[PATCH] D13351: [Power PC] add soft float support for ppc32

[hfinkel@anl.gov via cfe-commits]

hfinkel added inline comments.

================
Comment at: lib/CodeGen/TargetInfo.cpp:3421
@@ -3419,3 +3420,3 @@
 public:
-  PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+  PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes &CGT, bool SoftFloatABI) : DefaultABIInfo(CGT), IsSoftFloatABI(SoftFloatABI) {}
 
----------------
Line too long.

================
Comment at: lib/Driver/Tools.cpp:1353
@@ -1351,1 +1352,3 @@
 
+  // FIXME: Remove error for ppc64 when soft-float support is added.
+  ppc::FloatABI FloatABI = ppc::getPPCFloatABI(D, Args);
----------------
Remove this FIXME. It is not clear this will ever be supported (is there actually ppc64 hardware without an FP unit)?

================
Comment at: lib/Driver/Tools.cpp:1362
@@ +1361,3 @@
+            Triple.getArch() == llvm::Triple::ppc64le))
+    D.Diag(diag::err_drv_ppc64_softfloat_not_supported);
+
----------------
Don't introduce a new error for this. Just reuse the diag::err_drv_invalid_mfloat_abi error.


http://reviews.llvm.org/D13351