[PATCH] D14441: [OpenCL] Pipe types support.

[Anastasia Stulova via cfe-commits]

Anastasia added a subscriber: Anastasia.

================
Comment at: include/clang/AST/Type.h:5018
@@ +5017,3 @@
+/// PipeType - OpenCL20.
+///
+class PipeType : public Type, public llvm::FoldingSetNode {
----------------
Any reason for an empty comment line here?

================
Comment at: lib/AST/ASTContext.cpp:1848
@@ -1841,1 +1847,3 @@
+  }
+  break;
 
----------------
Break not needed?

================
Comment at: lib/AST/ItaniumMangle.cpp:2673
@@ +2672,3 @@
+void CXXNameMangler::mangleType(const PipeType *T) {
+  // Pipe type mangling rules are described in SPIR 2.0 specification.
+  // <type> ::= 8ocl_pipe
----------------
May be a reference to a section in the spec?

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2005
@@ +2004,3 @@
+                                     llvm::DIFile *U) {
+  // Ignore the atomic wrapping
+  // FIXME: What is the correct representation?
----------------
what does "atomic wrapping" mean here?

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2006
@@ +2005,3 @@
+  // Ignore the atomic wrapping
+  // FIXME: What is the correct representation?
+  return getOrCreateType(Ty->getElementType(), U);
----------------
Also I don't get this comment. But I see that it's copied from atomic.

================
Comment at: lib/Sema/SemaType.cpp:1941
@@ +1940,3 @@
+///
+/// \param Loc The location of the entity whose type involves this pointer type
+/// or, if there is no such entity, the location of the type that will have
----------------
Is "pointer type" correct here?

================
Comment at: lib/Sema/SemaType.cpp:4146
@@ +4145,3 @@
+      break;
+    }
+
----------------
Why this brace here?


http://reviews.llvm.org/D14441