[PATCH] D14877: Fix ICE on lowering of constexpr vector splats

[George Burgess IV via cfe-commits]

george.burgess.iv added inline comments.

================
Comment at: lib/CodeGen/CGExprConstant.cpp:1362-1363
@@ -1360,3 +1361,4 @@
+        Inits[I] = llvm::ConstantFP::get(VMContext, Elt.getFloat());
       else
-        Inits.push_back(llvm::ConstantFP::get(VMContext, Elt.getFloat()));
+        llvm_unreachable("unsupported vector element type");
     }
----------------
majnemer wrote:
> Is this unreachable for vectors of pointer type?
Might you have an example of how to use a vector of pointers in clang? My knowledge of vectors as a whole is super limited, so I'm probably missing something obvious, but I can't seem to get any of the vector types mentioned here http://clang.llvm.org/docs/LanguageExtensions.html#vectors-and-extended-vectors to accept a pointer element type, nor is my grep-fu good enough to find e.g. a `vector (int*)` in `test/`. 


http://reviews.llvm.org/D14877