[PATCH] D14737: Convert some ObjC msgSends to runtime calls

Pete Cooper via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 19 16:57:54 PST 2015


pete updated this revision to Diff 40719.
pete added a comment.

Thanks for all the feedback!

I've addressed all of your previous feedback and also applied clang-format to the whole patch as some parts were looking questionable.

BTW, each of the implementations of EmitObjC* ultimately called to emitARCValueOperation which handled the bit cast insertion when the dest type was not an id.  I've added a check for this in the test case, and verified that the IR looked good.

Let me know what you think.  Thanks!


http://reviews.llvm.org/D14737

Files:
  include/clang/Basic/ObjCRuntime.h
  include/clang/Driver/Options.td
  include/clang/Frontend/CodeGenOptions.def
  lib/CodeGen/CGObjC.cpp
  lib/CodeGen/CodeGenFunction.h
  lib/CodeGen/CodeGenModule.h
  lib/Driver/Tools.cpp
  lib/Frontend/CompilerInvocation.cpp
  test/CodeGenObjC/convert-messages-to-runtime-calls.m
  test/Driver/objc-convert-messages-to-runtime-calls.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14737.40719.patch
Type: text/x-patch
Size: 15669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151120/e5b7bc77/attachment-0001.bin>


More information about the cfe-commits mailing list