[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.
Jonathan Roelofs via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 15:00:09 PST 2015
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
I don't have any more comments, but I don't feel comfortable LGTM-ing this. I'll save that for Eric or Marshall.
================
Comment at: test/support/noexcept.h:14
@@ +13,3 @@
+#include<cstdio>
+#include<cstdlib>
+
----------------
s/</ </
================
Comment at: test/support/noexcept.h:20
@@ +19,3 @@
+// to jump between threads!
+thread_local jmp_buf try_buf;
+#else
----------------
I believe there are platforms that don't support `thread_local`, but which are not `_LIBCPP_HAS_NO_THREADS` platforms. I don't know of a good way to test for that :/ maybe @ericwf has an idea?
http://reviews.llvm.org/D14653
More information about the cfe-commits
mailing list