[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.
Jonathan Roelofs via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 10:21:35 PST 2015
jroelofs added inline comments.
================
Comment at: include/__noexcept:19
@@ +18,3 @@
+
+void __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
----------------
Make this:
void __attribute__((weak)) __libcxx_noexceptions_abort();
================
Comment at: include/__noexcept:36
@@ +35,3 @@
+ fprintf(stderr, "exception raised, cannot propagate. Aborting.\n");
+ __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
----------------
Then this should be:
if (__libcxx_noexceptions_abort)
__libcxx_noexceptions_abort();
else
abort();
================
Comment at: src/noexcept.cpp:1
@@ +1,2 @@
+//===------------------------ noexcept.cpp --------------------------------===//
+//
----------------
And delete this whole file.
http://reviews.llvm.org/D14653
More information about the cfe-commits
mailing list