[PATCH] D14737: Convert some ObjC msgSends to runtime calls

Pete Cooper via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 18 16:24:01 PST 2015


> On Nov 18, 2015, at 4:21 PM, John McCall <rjmccall at gmail.com> wrote:
> 
> rjmccall added inline comments.
> 
> ================
> Comment at: include/clang/Basic/ObjCRuntime.h:182
> @@ +181,3 @@
> +    switch (getKind()) {
> +    case FragileMacOSX: return false;
> +    case MacOSX: return getVersion() >= VersionTuple(10, 10);
> ----------------
> I went ahead and asked Greg, and he agreed that it's best to not enable this on the Mac fragile runtime.  The functions exist, but they aren't profitable to call, other than a small code-size decrease.
Ah cool.  Thanks for checking.

I’m working on updating the patch now with your feedback.  Should have a new version soon.

I will now also add tests to ensure the fragile runtime does not get this change, since i’d been missing that before.

Thanks,
Pete
> 
> 
> http://reviews.llvm.org/D14737
> 
> 
> 



More information about the cfe-commits mailing list