[PATCH] D14754: [Myriad]: insert -L paths into linker cmd only when they exist.

James Y Knight via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 17 14:32:04 PST 2015


jyknight added inline comments.

================
Comment at: lib/Driver/ToolChains.cpp:4319
@@ +4318,3 @@
+  // This contains libc, libg (a superset of libc), libm, libstdc++, libssp.
+  SmallString<128> LibDir(GCCInstallation.getParentLibPath());
+  if (Triple.getArch() == llvm::Triple::sparcel)
----------------
Should check GCCInstallation.isValid() before doing any of this.

================
Comment at: lib/Driver/ToolChains.cpp:4324
@@ +4323,3 @@
+    llvm::sys::path::append(LibDir, "../sparc-myriad-elf/lib");
+  if (getVFS().exists(LibDir))
+    getFilePaths().push_back(LibDir.str());
----------------
addPathIfExists instead of if/push_back.


http://reviews.llvm.org/D14754





More information about the cfe-commits mailing list