r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

[Yaron Keren via cfe-commits]

r253161

2015-11-14 22:45 GMT+02:00 Martell Malone <martellmalone at gmail.com>:

> The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't
> have symlinks.
> I figured passing flavor gets over this hurdle and the installation takes
> up less space.
> If you want to change it I have no objections we will just have to look at
> having lld's cmake to ensure it is created on Windows like we do for clang++
>
> The idea of forcing either lld or ld LGTM yaron.
> I don't think using MSVC link.exe makes any sense to mingw users.
>
> On Saturday, November 14, 2015, Yaron Keren <yaron.keren at gmail.com> wrote:
>
>> Filipe: with mingw targetting Windows/COFF files I think only ld and lld
>> makes sense as gold creates ELF files. I included Microsoft link.exe in the
>> mingw-useld test but rethinking, no one really uses that configuration, see
>> attached patch. Is that what you mean?
>>
>> Rafael: running under Windows which has symbolic links but they aren't
>> really used as much (or at all) as under Linux. For example clang-cl.exe
>> and clang++.exe are copies (not links) of clang.exe.
>>
>> Martell, what do you think?
>>
>>
>>
>> 2015-11-14 19:52 GMT+02:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>>
>>> On 15 November 2015 at 02:39, Filipe Cabecinhas <filcab at gmail.com>
>>> wrote:
>>> > Handling of values other than lld looked weird.
>>> > Can you make it a hard error to use something other than, I guess, ld,
>>> gold,
>>> > lld?
>>> > Or are there other linkers available?
>>>
>>> What I find strange is that we use -flavor at all. We should ideally
>>> just be using different links to lld, like we do with "-fuse-ld=lld2".
>>>
>>>
>>> Cheers,
>>> Rafael
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151115/0e44e64a/attachment.html>