[PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 13 19:45:19 PST 2015


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good with one nit. Thank you!


================
Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:23
@@ +22,3 @@
+  if (const auto *FnTy = Node.getType()->getAs<FunctionProtoType>()) {
+    // If any of the copy constructors is throwing, we will assume that it
+    // is plausible that the constructor may be selected by the throw and
----------------
The comment is not relevant now.


http://reviews.llvm.org/D14619





More information about the cfe-commits mailing list