[PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 12 07:32:37 PST 2015


aaron.ballman added inline comments.

================
Comment at: lib/CodeGen/CodeGenFunction.cpp:721
@@ +720,3 @@
+  // to be norecurse by the standard (3.6.1.3 "The function main shall not be
+  // used within a program")
+  if (getLangOpts().CPlusPlus)
----------------
Missing a period at the end of the sentence.

================
Comment at: test/CodeGenCXX/main-norecurse.cpp:1
@@ +1,2 @@
+// RUN: %clang_cc1 -emit-llvm %s -o -
+
----------------
jmolloy wrote:
> Wow, I managed to forget in my copy-paste from another test to add "| FileCheck %s" here.
> 
> I'll update this before committing.
Missing FileCheck?


Repository:
  rL LLVM

http://reviews.llvm.org/D14615





More information about the cfe-commits mailing list