[PATCH] D14592: Qt (version 4 or 5) signal/method checker

[Jonathan Roelofs via cfe-commits]

jroelofs added a subscriber: jroelofs.

================
Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
@@ +113,3 @@
+                         printMethodNameWithPramaTypes(Out, C, FName, M, false);
+                         const std::string NS = qtNormalizeSignature(Out.str());
+                         if (NS == MethodWithParamsNorm)
----------------
Why are you throwing away all the work that the parser did to build up the type signature as a QualType, pretty-printing it, and the re-parsing it by hand? ISTM it would be much better if qtNormalizeSignature had this type signature: `QualType qtNormalizeSignature(QualType)`.


http://reviews.llvm.org/D14592