[PATCH] D14583: Report Windows error code in a fatal error after a system call

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 11 12:36:56 PST 2015


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.

Also, I am really curious to know why CryptAcquireContext fails in those cases!


================
Comment at: lib/Support/Windows/Process.inc:421
@@ +420,3 @@
+// Include GetLastError() in a fatal error message.
+static void ReportLastErrorFatal(const char *msg) {
+  std::string ErrMsg;
----------------
msg should be Msg for style conventions.


http://reviews.llvm.org/D14583





More information about the cfe-commits mailing list