[PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 10 07:10:10 PST 2015


rmaprath added inline comments.

================
Comment at: buildbot/osuosl/master/config/builders.py:880
@@ +879,3 @@
+            # See: libcxxabi/test/lit.cfg
+            lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt.builtins-arm"'},
+            cmake_extra_opts={'LIBCXXABI_USE_LLVM_UNWINDER': 'True',
----------------
jroelofs wrote:
> The order here seems a bit off to me. I //think// it should be:
> 
>     lit_extra_opts={'link_flags': '"-lc++abi -lpthread -lunwind -ldl -lc -lm  -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt.builtins-arm"'},
@rengolin: If you are OK with Jon's suggestion, I can update both the configurations (I copied these lines from your existing A15 builder).


http://reviews.llvm.org/D14293





More information about the cfe-commits mailing list