[PATCH] D13834: Produce a better diagnostic for global register variables

[Eric Christopher via cfe-commits]

echristo added a comment.

My preference for this sort of thing would be an enum of failure reasons, but I guess this is ok for now. One inline request.

-eric


================
Comment at: lib/Basic/Targets.cpp:3978-3981
@@ +3977,6 @@
+                                      bool &HasSizeMismatch) const override {
+    if (RegName.equals("rsp") || RegName.equals("rbp")) {
+      HasSizeMismatch = RegSize != 64;
+      return true;
+    }
+
----------------
This could use a comment, what are you testing here?


http://reviews.llvm.org/D13834