[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D14502#285371, @aaron.ballman wrote:

> In http://reviews.llvm.org/D14502#285305, @bcraig wrote:
>
> > Does this affect the presence or functionality of the "INSTALL" project?
>
>
> There is no INSTALL project in MSVC from what I can see (before or after this patch), so I don't think that this affects that functionality.


I spoke too soon, I found it by squinting harder. It's in the CMakePredefinedTargets folder. What do INSTALL and PACKAGE actually *do*? For me, PACKAGE fails to build (CPack error : Cannot find NSIS compiler makensis: likely it is not installed, or not in your PATH), and INSTALL fails with the expected outcome (CMake Error at cmake_install.cmake: 31 (file): file INSTALL cannot make directory "C:/Program Files (x86)/LLVM/include/llvm": No such file or directory

I do not think we should have an INSTALL target for MSVC at all (unless it is building an installer, for instance). Installation requires user input, and likely also requires elevation. Having a project that does the wrong thing (for instance, all of my applications live on D:, not C:) doesn't seem fruitful as a project that is generated by default (but it could be useful to some people to be enabled via a CMake flag).


http://reviews.llvm.org/D14502