[PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

John McCall via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 16:06:43 PST 2015


rjmccall added a comment.

In http://reviews.llvm.org/D12614#284158, @sfantao wrote:

> As for the structor variants, I am now using the complete variant to generate the names of the kernels as you suggested. I didn't add any method to CXXABI as that will require extra logic in ASTContext to make that visible during the code generation. Instead, I hardcoded `Ctor[Dtor]_Complete` in the code generation, similarly to what is done in the name mangler. Let me know if you'd rather have the method in CXXABI.


I think just using the complete variant is a totally reasonable choice.

I'll try to take a look at the rest of the patch soon.

John.


http://reviews.llvm.org/D12614





More information about the cfe-commits mailing list