[PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 01:49:02 PST 2015


klimek added inline comments.

================
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+      const CommandLineArguments &Args, StringRef Filename) {
+    Context.setCurrentFile(Filename);
+    const ClangTidyOptions &Opts = Context.getOptions();
----------------
My concern is still with the Filename in the arg callback. I'd like to understand the full use-case better.
>From this code it looks like we want to change the ClangTidyContext's file and use the callback for that? That seems rather out of place, but maybe I'm missing something.


http://reviews.llvm.org/D14192





More information about the cfe-commits mailing list