[PATCH] D14184: [clang] Add initial support for -meabi flag

[Renato Golin via cfe-commits]

rengolin added inline comments.

================
Comment at: lib/Driver/Tools.cpp:3415
@@ -3414,1 +3414,3 @@
 
+  CmdArgs.push_back("-meabi");
+  if (Arg *A = Args.getLastArg(options::OPT_meabi))
----------------
Shouldn't we only add the option if it was used in the command line?

================
Comment at: lib/Frontend/CompilerInvocation.cpp:459
@@ +458,3 @@
+    StringRef Value = A->getValue();
+    bool Valid = llvm::StringSwitch<bool>(Value)
+                     .Case("default", true)
----------------
tinti wrote:
> This part of the code does not include TargetOptions.h (so EABI is an undefined type). Can I add it here?
If you mean up there, at the beginning of the file, then I suspect you should. Though, I though some other header would get it by now. If they don't, then please add it.


Repository:
  rL LLVM

http://reviews.llvm.org/D14184