[PATCH] D13925: Implement __attribute__((internal_linkage))

[Aaron Ballman via cfe-commits]

aaron.ballman added inline comments.

================
Comment at: lib/Sema/SemaDecl.cpp:6609
@@ +6608,3 @@
+
+  if (NewVD->hasLocalStorage() && NewVD->hasAttr<InternalLinkageAttr>()) {
+    Diag(NewVD->getLocation(), diag::warn_internal_linkage_local_storage);
----------------
Is there a reason this change cannot go into SemaDeclAttr.cpp instead? That way we don't bother to attach the attribute in the first place.

================
Comment at: lib/Sema/SemaDeclAttr.cpp:3407
@@ +3406,3 @@
+                                             : ExpectedVariableOrFunction);
+    D->dropAttr<AlwaysInlineAttr>();
+  }
----------------
Why is this dropping AlwaysInlineAttr instead of returning a nullptr?


Repository:
  rL LLVM

http://reviews.llvm.org/D13925