[PATCH] D13304: Avoid inlining in throw statement

[Jun Bum Lim via cfe-commits]

junbuml added a comment.

If we want to add a check for CallSites in EHRs in inliner, we may be able to borrow things done in BranchProbabilityInfo::calcColdCallHeuristics, but for exception handing intrinsics, not for cold,  and make getInlineThreshold() return a lower threshold so that we can be conservative for calls in EHR.

Considering that inliner will be hooked with BPI / BFI with the new pass manager, as Hal mentioned above we may need to mark the exception handling intrinsics as cold so that we can allow BranchProbabilityInfo::calcColdCallHeuristics to set weight properly for blocks that branch to exception regions. I believe we can do this at prune-eh if front-end don’t do that, but it could be done later.


http://reviews.llvm.org/D13304