r251713 - CGExprConstant.cpp: Appease Modules.

NAKAMURA Takumi via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 1 09:49:52 PST 2015


PR25368, https://llvm.org/bugs/show_bug.cgi?id=25368
Thanks!

On Sat, Oct 31, 2015 at 2:30 AM NAKAMURA Takumi <geek4civic at gmail.com>
wrote:

> I know. The builder was red for weeks (or months).
> Please be patient for my work. It's green now.
>
> I'll file bugs, two issues,  when I got a slack time.
>
> 2015年10月30日(金) 9:44 Richard Smith <richard at metafoo.co.uk>:
>
>> On Oct 30, 2015 6:39 AM, "NAKAMURA Takumi via cfe-commits" <
>> cfe-commits at lists.llvm.org> wrote:
>> >
>> > Author: chapuni
>> > Date: Fri Oct 30 11:37:27 2015
>> > New Revision: 251713
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=251713&view=rev
>> > Log:
>> > CGExprConstant.cpp: Appease Modules.
>>
>> Why? Please don't work around modules bugs to make the buildbot green;
>> the purpose of the bot is to find those bugs.
>>
>> > Modified:
>> >     cfe/trunk/lib/CodeGen/CGExprConstant.cpp
>> >
>> > Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp
>> > URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprConstant.cpp?rev=251713&r1=251712&r2=251713&view=diff
>> >
>> ==============================================================================
>> > --- cfe/trunk/lib/CodeGen/CGExprConstant.cpp (original)
>> > +++ cfe/trunk/lib/CodeGen/CGExprConstant.cpp Fri Oct 30 11:37:27 2015
>> > @@ -1038,7 +1038,7 @@ public:
>> >        unsigned Type = cast<PredefinedExpr>(E)->getIdentType();
>> >        if (CGF) {
>> >          LValue Res =
>> CGF->EmitPredefinedLValue(cast<PredefinedExpr>(E));
>> > -        return cast<ConstantAddress>(Res.getAddress());
>> > +        return llvm::cast<ConstantAddress>(Res.getAddress());
>> >        } else if (Type == PredefinedExpr::PrettyFunction) {
>> >          return CGM.GetAddrOfConstantCString("top level", ".tmp");
>> >        }
>> >
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151101/d270029c/attachment.html>


More information about the cfe-commits mailing list