[PATCH] D14184: [clang] Add initial support for -meabi flag

[Saleem Abdulrasool via cfe-commits]

compnerd added a comment.

This looks like what I had in mind wrt use of `-meabi`.


================
Comment at: lib/CodeGen/BackendUtil.cpp:524
@@ +523,3 @@
+      .Case("5",   llvm::EABI::Eabi5)
+      .Case("gnu", llvm::EABI::Gnu)
+      .Default(llvm::EABI::Default);
----------------
I'd really rather see this written in the LLVM Style:

    EABI4, EABI5, GNU

since all of them are initialisms.

BTW, please clang-format this change.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:458
@@ +457,3 @@
+    StringRef Value = A->getValue();
+    bool Valid = llvm::StringSwitch<bool>(Value)
+      .Case("default", true)
----------------
If `llvm::EABI::EABIVersionType` had an `Invalid` value in the enumeration, you could convert directly to the value here, and report the error if the value was `Invalid`.


http://reviews.llvm.org/D14184