[PATCH] Bug 15109: Implement -Wdouble-promotion for clang

[Carl Norum via cfe-commits]

OK, here you go!

-- Carl


-------------- next part --------------
A non-text attachment was scrubbed...
Name: double-promotion-2.patch
Type: application/octet-stream
Size: 4060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151028/5b81e037/attachment.obj>
-------------- next part --------------

> On Oct 28, 2015, at 4:53 PM, Carl Norum <carl.norum at apple.com> wrote:
> 
> 
>> On Oct 28, 2015, at 4:37 PM, George Burgess IV <george.burgess.iv at gmail.com> wrote:
>> 
>> Thanks for this patch! :) Just a few small nits:
>> - Is there a reason that test/SemaCXX/warn-double-promotion.cpp can't be at test/Sema/warn-double-promotion.c instead?
> 
> No reason; I just found warn-float-conversion.c in there and this code is similar. Can move easily.
> 
>> - Can we make the warning message a bit more specific? Maybe something like "implicit conversion increases floating-point precision: %0 to %1"?
> 
> Sure thing.
> 
>> - Please get rid of the empty line after `else if (TargetBT->getKind() > SourceBT->getKind()) {`
> 
> NP. Will send a patch shortly.
> 
>> After those are fixed, LGTM -- will you need me to commit this for you?
> 
> I think so yes.
> 
> -- Carl
> 
> 
>> On Tue, Oct 27, 2015 at 9:45 PM, Carl Norum via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>> Hi folks,
>> 
>> I had need of this warning, so I cobbled something together. Can someone please check it out and let me know if it's reasonable? I'm certainly no expert at this stuff. Patch attached for review, thanks!
>> 
>> -- Carl
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>> 
>> 
>