[PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

[Renato Golin via cfe-commits]

rengolin added inline comments.

================
Comment at: lib/Driver/ToolChain.cpp:472
@@ -471,2 +471,3 @@
+    bool ThumbDefault = (ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
       (Suffix.startswith("v7") && getTriple().isOSBinFormatMachO());
     // FIXME: this is invalid for WindowsCE
----------------
You could cache the profile and use it here, too.

================
Comment at: test/Driver/arm-ias-Wa.s:75
@@ +74,3 @@
+
+// RUN: %clang -target thumbv7m-none-eabi -c %s -### 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK-M-PROFILE %s
----------------
You should also add "armv7m" and check that it defaults to Thumb, no?


http://reviews.llvm.org/D14121