[PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

Alexandros Lamprineas via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 09:40:34 PDT 2015


labrinea added inline comments.

================
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+    if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+        (InputType != types::TY_PP_Asm &&
+         Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb, ThumbDefault)))
----------------
Alternatively we could remove the check of InputType. I am not sure why this and the above comment are present anyway.


http://reviews.llvm.org/D14121





More information about the cfe-commits mailing list