[PATCH] D14104: clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 03:42:14 PDT 2015


klimek added inline comments.

================
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+  if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+      Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+      (!Previous.Previous ||
----------------
djasper wrote:
> klimek wrote:
> > Is State.Column > getNewLineColumn(State) used to check for the line break?
> No. It is so that we don't enforce a break when it is not conserving columns, e.g. we'd still do:
> 
>   f(aaaa,
>     bbbb);
Ah, please add that to the comment then (it is surprising to me that this is wanted in always-break mode).


http://reviews.llvm.org/D14104





More information about the cfe-commits mailing list