[PATCH] D10305: [Clang Static Analyzer] Bug identification

Honggyu Kim via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 04:26:04 PDT 2015


honggyu.kim added a comment.

Hi Gabor,

I was away from the office for 3 weeks so I couldn't catch up the issues but you almost completed the patch now.
Thanks for this work!

I just found a tiny problem and described it in the line comment so please have a look at it.


================
Comment at: utils/analyzer/CmpRuns.py:73
@@ -72,2 +72,3 @@
           id += self._data['issue_context'] + "+"
         if 'issue_hash' in self._data :
+          id += str(self._data['issue_hash_function_offset'])
----------------
I think we should also modify 'issue_hash' to 'issue_hash_content_of_line_in_context' in if statement.


http://reviews.llvm.org/D10305





More information about the cfe-commits mailing list