r250473 - Add an error when calling a builtin that requires features that don't

Dimitry Andric via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 17 04:30:41 PDT 2015


On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> 
> Author: echristo
> Date: Thu Oct 15 18:47:11 2015
> New Revision: 250473
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev
> Log:
> Add an error when calling a builtin that requires features that don't
> match the feature set of the function that they're being called from.
...
> +def err_builtin_needs_feature : Error<"%0 needs target feature %1">;

Thanks.  Note, a typical error message now becomes something pretty terse, like this:

'__builtin_foo' needs target feature bar

It would be helpful if the error message gave some sort of hint on what the actual problem is (wrong -march parameter, probably?), and how to fix it.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151017/1bf0455d/attachment.sig>


More information about the cfe-commits mailing list