[PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

[Eric Fiselier via cfe-commits]

EricWF added inline comments.

================
Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:123-133
@@ +122,13 @@
+  else(WIN32)
+    if(UNIX)
+      set(LLVM_ON_WIN32 0)
+      set(LLVM_ON_UNIX 1)
+      if(APPLE)
+        set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
+      else(APPLE)
+        set(LLVM_HAVE_LINK_VERSION_SCRIPT 1)
+      endif(APPLE)
+    else(UNIX)
+      MESSAGE(SEND_ERROR "Unable to determine platform")
+    endif(UNIX)
+  endif(WIN32)
----------------
vkalintiris wrote:
> I've created the review request D13025, that checks whether version scripts are supported in non-APPLE Unix platforms. As far as I know, LLD doesn't support version scripts at the moment. Would it make sense to check this in a similar fashion for out of tree LLVM?
Thank's for the heads up. I'm actually using this incorrectly to mean "linker script" and not specifically a version script. After grepping the lld sources it seems that it does support linker scripts with the "INPUT" command in them, but I haven't tested it.

Really I should just change my uses of "LLVM_HAVE_LINK_VERSION_SCRIPT" to "LLVM_UNIX AND NOT APPLE" which is really what I'm trying to say. After doing that I can probably just remove the "LLVM_HAVE_LINK_VERSION_SCRIPT" from libc++ entirely.


http://reviews.llvm.org/D13739