[PATCH] D13516: Fix overlapping replacements in clang-tidy.
Manuel Klimek via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 16 04:24:20 PDT 2015
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:489
@@ +488,3 @@
+ std::vector<bool> Apply(Errors.size(), true);
+ int Count = 0;
+ for (const auto &Event : Events) {
----------------
Perhaps call this OpenIntervals, or if you like it short, just Open.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:493-494
@@ +492,4 @@
+ --Count;
+ // This have to be checked after removing the interval from the count if it
+ // is an end event, or before adding it if it is a begin event.
+ if (Count != 0)
----------------
s/have/has/
http://reviews.llvm.org/D13516
More information about the cfe-commits
mailing list