[PATCH] D13516: Fix overlapping replacements in clang-tidy.

Angel Garcia via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 15 02:52:41 PDT 2015


angelgarcia updated this revision to Diff 37465.
angelgarcia added a comment.

I did several mutations and the only case were a test didn't break was when I removed the sort, but it turned out that we don't need it. I changed the tests to apply the checks in both orders to ensure that a test will break if the errors are not sorted.

I am still thinking about how to complete Daniel's idea.


http://reviews.llvm.org/D13516

Files:
  clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tidy/ClangTidyDiagnosticConsumer.h
  unittests/clang-tidy/OverlappingReplacementsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13516.37465.patch
Type: text/x-patch
Size: 18838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151015/ef22464c/attachment-0001.bin>


More information about the cfe-commits mailing list