[PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

Christopher Bergström via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 13:41:23 PDT 2015


cbergstrom added a comment.

‎And does this hardcode the abi and break cxxrt? It's not just me who uses that 

  Original Message  
From: Eric Fiselier
Sent: Thursday, October 15, 2015 03:26
To: eric at efcs.ca; mclow.lists at gmail.com; jonathan at codesourcery.com; danalbert at google.com; compnerd at compnerd.org
Reply To: reviews+http://reviews.llvm.org/D13739+public+524ebe3e6873e8d5@reviews.llvm.org
Cc: emaste at freebsd.org; renato.golin at linaro.org; cbergstrom at pathscale.com; cfe-commits at lists.llvm.org
Subject: [PATCH] http://reviews.llvm.org/D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF created this revision.
EricWF added reviewers: mclow.lists, jroelofs, danalbert, compnerd.
EricWF added subscribers: cfe-commits, cbergstrom, rengolin, emaste.

This patch turns on `LIBCXX_ENABLE_ABI_LINKER_SCRIPT` by default whenever `LLVM_HAVE_LINK_VERSION_SCRIPT` is ON. This turns out to be whenever:

1. WIN32 is not defined.

2 UNIX is defined.

3. APPLE is not defined.

While `LLVM_HAVE_LINK_VERSION_SCRIPT` is meant to reflect exactly what we are asking I think it's close enough.

After committing this patch Linux users will no longer have to use "-lc++abi" explicitly!

http://reviews.llvm.org/D13739

Files:
CMakeLists.txt
cmake/Modules/HandleOutOfTreeLLVM.cmake
docs/BuildingLibcxx.rst
docs/UsingLibcxx.rst


http://reviews.llvm.org/D13739





More information about the cfe-commits mailing list