[PATCH] D13516: Fix overlapping replacements in clang-tidy.

Angel Garcia via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 02:03:45 PDT 2015


angelgarcia added a comment.

> These need to be documented.


Done.

> I'd name this Queue instead (reading later I had no idea what this was).


Done.

> Why are you calling this "Sit"?


I didn't even know how to describe this variable without using examples,
and naming it is harder. More or less, it keeps track of the different
overlapping situations that have been spotted during the process, so "Sit"
stands for that. But I know it is a really poor name and I'd like to change
it, any ideas?

Why do we need to sort?

> 


It's a remnant of a different approach that I tried before. Removed.


http://reviews.llvm.org/D13516





More information about the cfe-commits mailing list