r250252 - This patch adds missing pieces to clang, including the PS4 toolchain

[Ed Maste via cfe-commits]

On 13 October 2015 at 23:40, Ekaterina Romanova via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: kromanova
> Date: Tue Oct 13 18:40:02 2015
> New Revision: 250252
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250252&view=rev
> Log:
> This patch adds missing pieces to clang, including the PS4 toolchain
> definition, added warnings, PS4 defaults, and Driver changes needed for
> our compiler.

This broke the build on FreeBSD:

../tools/clang/lib/Driver/ToolChains.cpp:4083:17: error: use of
undeclared identifier 'EnvValue'
    PS4SDKDir = EnvValue;
                ^
../tools/clang/lib/Driver/ToolChains.cpp:4084:5: error: expected unqualified-id
  } else {
    ^
../tools/clang/lib/Driver/ToolChains.cpp:4094:3: error: expected unqualified-id
  if (const Arg *A = Args.getLastArg(options::OPT_isysroot)) {
  ^
../tools/clang/lib/Driver/ToolChains.cpp:4098:5: error: expected unqualified-id
  } else
    ^
../tools/clang/lib/Driver/ToolChains.cpp:4102:20: error: C++ requires
a type specifier for all declarations
  llvm::sys::path::append(PS4SDKIncludeDir, "target/include");
  ~~~~             ^
../tools/clang/lib/Driver/ToolChains.cpp:4103:3: error: expected unqualified-id
  if (!Args.hasArg(options::OPT_nostdinc) &&
  ^
../tools/clang/lib/Driver/ToolChains.cpp:4112:33: error: unknown type
name 'PS4SDKDir'
  SmallString<512> PS4SDKLibDir(PS4SDKDir);
                                ^
../tools/clang/lib/Driver/ToolChains.cpp:4113:20: error: C++ requires
a type specifier for all declarations
  llvm::sys::path::append(PS4SDKLibDir, "target/lib");
  ~~~~             ^
../tools/clang/lib/Driver/ToolChains.cpp:4114:3: error: expected unqualified-id
  if (!Args.hasArg(options::OPT_nostdlib) &&
  ^
../tools/clang/lib/Driver/ToolChains.cpp:4124:17: error: expected
function body after function declarator
  getFilePaths().push_back(PS4SDKLibDir.str());
                ^
../tools/clang/lib/Driver/ToolChains.cpp:4125:1: error: extraneous
closing brace ('}')
}