[PATCH] D11740: ABI versioning macros for libc++

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 16:17:12 PDT 2015


jroelofs added inline comments.

================
Comment at: include/__config_site.in:13
@@ -12,1 +12,3 @@
 
+#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@
+#cmakedefine _LIBCPP_ABI_UNSTABLE
----------------
jroelofs wrote:
> This doesn't look right to me. What do you want this to expand to when it is defined, and what do you want it to expand to when it is not defined?
Never mind. After re-reading the cmake docs, I see what it's supposed to do.


Repository:
  rL LLVM

http://reviews.llvm.org/D11740





More information about the cfe-commits mailing list