[PATCH] D11740: ABI versioning macros for libc++

[Eric Fiselier via cfe-commits]

EricWF added a comment.

Please address the inline comment. I think with that change we can hold off modifying libc++abi.


================
Comment at: test/libcxx/test/config.py:444
@@ -442,1 +443,3 @@
 
+    def configure_compile_flags_abi_version(self):
+        abi_version = self.get_lit_conf('abi_version', '').strip()
----------------
Please allow abi_version to be optional before committing. IE

```
abi_version = self.get_lit_conf('abi_version',  None)
if abi_version is not None:
  self.cxx.compile_flags += ['-D_LIBCPP_ABI_VERSION=' + abi_version']
```

That should allow us to put off the changes to libc++abi.


Repository:
  rL LLVM

http://reviews.llvm.org/D11740