[PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

[Aaron Ballman via cfe-commits]

aaron.ballman closed this revision.
aaron.ballman added a comment.

In http://reviews.llvm.org/D13510#262084, @mgehre wrote:

> The user will see [cppcoreguidelines-c-copy-assignment-signature] in warnings, but there is no
>  docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.rst.
>
> The user won't know that he needs to look for misc-assign-operator-signature.


I think this is a good point, but requires more engineering and discussion than this single patch should handle. Checkers registered under multiple names will have to figure something out for documentation.

> Maybe create a link to docs/clang-tidy/checks/misc-assign-operator-signature.rst?

>  (and also add it to docs/clang-tidy/checks/list.rst)


That's not a bad fallback solution if we don't come up with something better as part of the larger documentation discussion.

> Also, users reading the documentation will not see that cppcoreguidelines-c-copy-assignment-signature is available.


-checks=* -list-checks does show it as being available.

I have commit in r250165. As for the documentation discussion, I would like to have one, but not when I'm about to embark on a two-week vacation. If the discussion doesn't start by early Nov, I hope to circle back around to it then.

Thanks!

~Aaron


http://reviews.llvm.org/D13510