[PATCH] D13549: Added new options to ClangFormat VSIX package.

[Manuel Klimek via cfe-commits]

klimek added inline comments.

================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+            if (!string.IsNullOrEmpty(assumeFilename))
+              process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";
             process.StartInfo.CreateNoWindow = true;
----------------
curdeius wrote:
> klimek wrote:
> > Don't we need " escaping for assumeFilename? (or do we consider that an error? in which case, would we want to make that an error?)
> Well, quotes (") are not allowed as a part of a file name on Windows.
> What we could do is to strip surrounding quotes if the user added them in order not to add them twice.
Oh, I didn't know that.
My main concern is what happens when the user (accidentally) adds quotes (for example, unbalanced) and messes up the command line in a way that leads to a super hard to diagnose problem


http://reviews.llvm.org/D13549