[PATCH] D13549: Added new options to ClangFormat VSIX package.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 02:34:31 PDT 2015


klimek added inline comments.

================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186
@@ -145,1 +185,3 @@
+            if (!string.IsNullOrEmpty(assumeFilename))
+              process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";
             process.StartInfo.CreateNoWindow = true;
----------------
Don't we need " escaping for assumeFilename? (or do we consider that an error? in which case, would we want to make that an error?)


http://reviews.llvm.org/D13549





More information about the cfe-commits mailing list