[PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

[Eric Fiselier via cfe-commits]

EricWF marked an inline comment as done.

================
Comment at: include/CMakeLists.txt:38
@@ +37,3 @@
+      COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >> ${LIBCXX_BINARY_DIR}/__generated_config
+      DEPENDS ${LIBCXX_SOURCE_DIR}/include/__config
+    )
----------------
eugenis wrote:
> I think you need to depend on __config_site.in as well. Or on ${LIBCXX_BINARY_DIR}/__config_site 
I don't think we need it. `__config_site` is generated with `configure_file`, which runs at configuration time and re-runs whenever the input file is changed. So `__config_site` should always be up to date. 

However I'll see if we can actually make the change. It seems clearer and safer.


http://reviews.llvm.org/D13407