[PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 9 16:56:56 PDT 2015


EricWF marked an inline comment as done.
EricWF added a comment.

@eugenis I'll commit this tuesday morning If I don't hear anything over the weekend (Monday is a holiday for me).
If you rebase the ABI patch to work with this I'll make sure to review it ASAP.


================
Comment at: include/CMakeLists.txt:9
@@ -7,2 +8,3 @@
   PATTERN ".svn" EXCLUDE
+  PATTERN "__config_site.in" EXCLUDE
   ${LIBCXX_SUPPORT_HEADER_PATTERN}
----------------
vkalintiris wrote:
> Kind of silly but I believe that the files used for auto-generated config headers in LLVM have the extesions `.cmake` and `.in`, for cmake and autoconf, respectively.
libc++ uses `.cmake` for CMake scripts and `.in` for auto-generated files and I think this is fine. libc++ doesn't support autoconf I'm not worried about it causing confusion. 



http://reviews.llvm.org/D13407





More information about the cfe-commits mailing list