r249894 - Add a fixme to handleTargetFeatures.

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 9 13:30:48 PDT 2015


Author: echristo
Date: Fri Oct  9 15:30:48 2015
New Revision: 249894

URL: http://llvm.org/viewvc/llvm-project?rev=249894&view=rev
Log:
Add a fixme to handleTargetFeatures.

The goal of wanting this to avoid munging the feature list is so
that it can be used for various targets as a way of both adding
and verifying the features that are going to be output into the
IR.

Modified:
    cfe/trunk/include/clang/Basic/TargetInfo.h

Modified: cfe/trunk/include/clang/Basic/TargetInfo.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/TargetInfo.h?rev=249894&r1=249893&r2=249894&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/TargetInfo.h (original)
+++ cfe/trunk/include/clang/Basic/TargetInfo.h Fri Oct  9 15:30:48 2015
@@ -801,6 +801,8 @@ public:
   ///
   /// The target may modify the features list, to change which options are
   /// passed onwards to the backend.
+  /// FIXME: This part should be fixed so that we can change handleTargetFeatures
+  /// to merely a TargetInfo initialization routine.
   ///
   /// \return  False on error.
   virtual bool handleTargetFeatures(std::vector<std::string> &Features,




More information about the cfe-commits mailing list