[PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 11:19:36 PDT 2015


sfantao added a comment.

Thanks for the comments!


================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+  /// far.
+  struct OffloadEntriesInfoManagerTy {
+    CodeGenModule &CGM;
----------------
ABataev wrote:
> Maybe it is better to make it a class if it has some non-public members?
Ok, replaced struct by class in `OffloadEntriesInfoManagerTy` and the other subtypes that have either private or protected fields.



http://reviews.llvm.org/D12614





More information about the cfe-commits mailing list