[PATCH] D13453: Always generate cmake config files

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 10:38:13 PDT 2015


rnk added a comment.

I added this conditional check in r221415, with this message:

  cmake: Only export targets in the standalone build
  
  Trying to fix bots that didn't like the fact that I exported targets
  that depended on LLVM without exporting targets from LLVM.

I assume this has already been addressed in LLVM? We now export targets there so we can depend on them in clang's exported targets file? If so, I'm happy to make this check simply conditional on the CMake version like you suggest.

I'm not actually a good reviewer for these kinds of things, I know very little about cmake package exports. =/ When I made this code change, I was just trying to hack the standalone build into shape. I haven't really used it since.


http://reviews.llvm.org/D13453





More information about the cfe-commits mailing list