Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 10:31:45 PDT 2015


zaks.anna added a comment.

> Even if you do not deal with this case I think it would be great to have an XFAIL test with a fixme that describes this limitation.


Yes! Every time we have a test case that shows known limitations, we should add it to the regression tests with a TODO explaining the issue. (I would not add it as a separate test that is XFAILed but rather add to an existing test file at the very end in the TODO or FIXME section. )


http://reviews.llvm.org/D13099





More information about the cfe-commits mailing list