[PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 6 06:13:32 PDT 2015


klimek added inline comments.

================
Comment at: unittests/clang-tidy/OverlappingReplacementsTest.cpp:133
@@ +132,3 @@
+
+TEST(OverlappingReplacementsTest, TestingChecksWorkAsExpected) {
+  const char Code[] =
----------------
I'd split it up and give the tests better names. TestingChecksWorksAsExpected doesn't really give new information :)


http://reviews.llvm.org/D13469





More information about the cfe-commits mailing list