[PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/Sema/SemaType.cpp:6282
@@ +6281,3 @@
+    } else if (state.getCurrentChunkIndex() == 0 &&
+               D.getContext() == Declarator::FileContext &&
+               !D.isFunctionDeclarator() && !D.isFunctionDefinition() &&
----------------
pekka.jaaskelainen wrote:
> Should this "white list" the cases where it's safe to add the default AS, not assume that it's applicable to any not listed here? Maybe safer that way.
It seems like there are no corresponding helper methods available in Declarator. So the code is therefore using negation everywhere. But also if we would add a helper function, I think we would implement it as a form of negation anyways.


http://reviews.llvm.org/D13168