[libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

[Adrian Prantl via cfe-commits]

> On Oct 3, 2015, at 4:33 PM, Eric Fiselier <eric at efcs.ca> wrote:
> 
> Hi Adrian,
> 
> So the goal of this patch was to increase the coverage of the test
> suite by default.
> Previously we used C++11 as the default but this meant that new C++14
> and C++1z tests
> were never run.  The failures you are seeing are all C++14 tests.
> 
> We should work on actually fixing the failing tests. Reverting the
> commit will only
> hide these test failures again.

While reverting the patch won’t help solving the problem your patch uncovered, getting the bot green again is very important in itself, as the bots are configured to only send a notification when a bot transitions from green -> failed, and thus we won’t get alerted of any additional test failures that happen in while the bot is failing.

If it doesn’t cause too much inconvenience, I would highly appreciate reverting the change now and then recommitting it together with the fix to keep the bots working.

> 
> All of the errors seem to be caused by latent problems in how libc++ links to
> libc++abi. on Apple platforms. libc++ always uses the system provided
> libc++abi even
> when it should use a newer version.

Yes, I was surprised to see the host libc++ appear in the linker command in a libc++ test.

> 
> I *think* I know how to fix these issues but I would appreciate an Apple expert
> to look at the fixes. Would you be able to help?

I’d be happy to work with you on getting this fixed — be it by reviewing the changes or by pulling in more domain experts :-)

thanks!
adrian

> 
> /Eric