[PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

Matthias Gehre via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 4 05:49:02 PDT 2015


mgehre marked 2 inline comments as done.
mgehre added a comment.

Thank you for the detailed review.
I disabled checks in template instantiations for now.
Ideally, I would want to see something like:

  warning: do not use static_cast to cast from base class to derived class.
  note: in instantiation of function template specialization ... requested here ...

This must be without fixit to no break other users of the template (e.g. where other users use non-polymorphic types).
How can I add that "note: in instantiation" line to the diagnostic of the check?


http://reviews.llvm.org/D13368





More information about the cfe-commits mailing list